[IR] Add an IR Builder with some basic functions #2204
Conversation
xumingkuan
requested review from
yuanming-hu,
BillXu2000,
k-ye and
taichi-gardener
|
|
||
| class IRBuilder { | ||
| public: | ||
| struct InsertPoint { |
There was a problem hiding this comment.
I'm not sure if we need to modify the insertion point... I think it's fine to make it private now.
There was a problem hiding this comment.
Great! LGTM.
However, we cannot use the new
IRBuilderto build a whole program now, since the constructorKernel::Kernel()fetches the IR fromASTBuilder. I'm not sure how to solve it -- would it be fine to simply add a constructor to theKernelclass, and let developers call it to use the newIRBuilder?
Your solution sounds good!
| Stmt *insert(std::unique_ptr<Stmt> &&stmt); | ||
|
|
||
| // Constants. TODO: add more types | ||
| Stmt *get_int32(int32 value); |
There was a problem hiding this comment.
You may also consider a template <typename T> Stmt *get_const(T val) template function and then specialize for different types (or use if constexpr (std::is_same_v<T, int32>)). Just a random idea and the decision is yours :-)
Related issue = #2193
This PR renames the existing
IRBuilderclass toASTBuilder, since it actually builds the frontend AST in C++.The
IRBuildernewly added in this PR is able to build the following instructions now:DataType dt, bool is_ptrarguments is a good idea)However, we cannot use the new
IRBuilderto build a whole program now, since the constructorKernel::Kernel()fetches the IR fromASTBuilder. I'm not sure how to solve it -- would it be fine to simply add a constructor to theKernelclass, and let developers call it to use the newIRBuilder?And... the new
IRBuilderis not unit-tested now.[Click here for the format server]