Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Refactor release workflow to upload the wheel artifacts #2186

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Feb 11, 2021

Related issue = #2185

I did some cleanup to python/build.py. The change is actually not as large as it appears, because I was mostly grouping lots of the global statements into functions. A new mode, build, is added to this script, which only builds the wheels into python/dist, but doesn't do the upload. Also added an option --skip_build.

The release job now becomes:

  1. python build.py build: builds the wheels without uploading.
  2. Archive Wheel Artifacts: make the wheel files the artifacts of this job. (Unfortunately, I haven't found a way to include the release tag in the artifacts.) In case the final PyPI upload step failed, we still have a way to access these wheels and upload them manually.
  3. python build.py try_upload --skip_build: Try uploading the wheels built from step 1.

Tested in https://github.com/k-ye/test_gh_action/pull/10/checks?check_run_id=1879776553

[Click here for the format server]


Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

In case the final PyPI upload step failed, we still have a way to access these wheels and upload them manually.

Not sure if this is related: sometimes the wheels fail just because PyPI runs out of space. Since we need to ship binaries the wheels take much larger space than a normal Python project. I manually deleted a few unimportant releases to save space, but we should try to systematically fix this when we have time (e.g., email PyPI and ask for more space).

@yuanming-hu yuanming-hu merged commit 08ed85a into taichi-dev:master Feb 11, 2021
@k-ye
Copy link
Member Author

k-ye commented Feb 12, 2021

I manually deleted a few unimportant releases to save space, but we should try to systematically fix this when we have time (e.g., email PyPI and ask for more space).

Ah, I was mostly afraid if there is still some problem in the Github Action workflow :)

@k-ye k-ye deleted the fix-mac branch February 12, 2021 22:48
@k-ye k-ye mentioned this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants