Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Fix ti.GUI.MOVE not working on win32 and cocoa #2132

Merged
merged 1 commit into from
Jan 1, 2021

Conversation

archibate
Copy link
Collaborator

Related issue = A windows Taichi THREE user reports

[Click here for the format server]


To reproduce:

import taichi as ti

gui = ti.GUI()
while gui.running:
    for e in gui.get_events():
        print(e.type, e.key)
    gui.show()

You should see no Motion event when your mouse is moving above the window. (Didn't have a win env to reproduce yet, but I let that win user to help me confirmed that this is reproduced)
But this works fine on X11:

EType.Move Motion
EType.Move Motion
EType.Move Motion
EType.Move Motion
EType.Move Motion
...

Please merge this fix soon so that windows and mac users could enjoy orbiting camera around in Taichi THREE 😃

@k-ye Would you mind help me confirm the cocoa part works (by using the reproduce code)? Thank in advance!

@archibate archibate changed the title [GUI] fix ti.GUI.MOVE not working on win32 and cocoa [GUI] Fix ti.GUI.MOVE not working on win32 and cocoa Dec 30, 2020
Copy link
Contributor

@JYLeeLYJ JYLeeLYJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi , this code already works well on Win after my confirmation.

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@archibate archibate merged commit 2c322d4 into taichi-dev:master Jan 1, 2021
@k-ye k-ye mentioned this pull request Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants