Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type] Fix struct-for on bit_struct #2129

Merged
merged 3 commits into from
Dec 29, 2020

Conversation

TH3CHARLie
Copy link
Collaborator

@TH3CHARLie TH3CHARLie requested a review from Hanke98 December 29, 2020 05:15
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TH3CHARLie
Copy link
Collaborator Author

The new added test passed locally while failed in CI, investigating...

@xumingkuan
Copy link
Contributor

The new added test passed locally while failed in CI, investigating...

This PR seems not based on the latest master branch -- try merging master into this branch?

Copy link
Contributor

@Hanke98 Hanke98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks!

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@yuanming-hu yuanming-hu merged commit dd1c8bf into taichi-dev:master Dec 29, 2020
@k-ye k-ye mentioned this pull request Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants