Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type] Add BitStructStoreStmt and corresponding passes #2128

Merged
merged 10 commits into from
Dec 29, 2020

Conversation

yuanming-hu
Copy link
Member

@yuanming-hu yuanming-hu commented Dec 29, 2020

Related issue = #1905

benchmark_bit_struct_stores.py:

  • CPU: 805ms -> 271ms
  • CUDA: 13.6ms -> 6.73 ms

[Click here for the format server]


@yuanming-hu yuanming-hu merged commit 931046f into taichi-dev:master Dec 29, 2020
@xumingkuan
Copy link
Contributor

I'm not sure how will BitStructStoreStmt affect data_sourse_analysis.cpp and other potential IR optimizations assuming GlobalStoreStmt and AtomicOpStmt are the only statements modifying global fields. However, we are good now as long as this pass is after all other optimizations.

@yuanming-hu yuanming-hu deleted the fused-store branch December 29, 2020 15:29
@yuanming-hu
Copy link
Member Author

I'm not sure how will BitStructStoreStmt affect data_sourse_analysis.cpp and other potential IR optimizations assuming GlobalStoreStmt and AtomicOpStmt are the only statements modifying global fields. However, we are good now as long as this pass is after all other optimizations.

Exactly. It seems that we need clear separations between the optimization passes in the future...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants