[type] Support offset load in bit vectorized loop #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
approved these changes
Dec 31, 2020
| ti.bit_vectorize(32) | ||
| for i, j in x: | ||
| y[i, j] = x[i, j + 1] | ||
| z[i, j] = x[i, j - 1] |
There was a problem hiding this comment.
If we are ready, we can test x[i - 1, j]/x[i + 1, j] too. You can also allocate only the y field, and reuse the functions assign_vectorized and verify by adding template arguments dx: ti.template(), dy: ti.template(), and the loop bodies should be something like y[i, j] = x[i + dx, j + dy].
Co-authored-by: Yuanming Hu <[email protected]>
Co-authored-by: Yuanming Hu <[email protected]>
Co-authored-by: Yuanming Hu <[email protected]>
Co-authored-by: Yuanming Hu <[email protected]>
|
Thanks for the review and help along the way! |
yuanming-hu
approved these changes
Dec 31, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1905
[Click here for the format server]