[type] Support exponents in CustomFloatType #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TH3CHARLie @Hanke98 I'm directly merging this PR to move forward. If you are interested in this, feel free to take a look :-) otherwise, please focus on the quantized GoL/fluid demos which are more important. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1905
TypeFactoryPython classCustomFloatTypenow supports exponents (GlobalLoad/Store)shared_exponentAPI (implementation in the next PR)place(CustomFloatType)SNodes now has a pointer to its exponent SNodebit_structSNode now hasbit_offset(This is, unfortunately, a lot of implementation details and "magic" numbers, especially the conversion between
CustomFloatTypeand IEEE 754f32).[Click here for the format server]