[type] [bug] Fix global load of CustomFloatType on CUDA #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanke98
commented
Dec 22, 2020
Comment on lines
+64
to
+83
| @ti.kernel | ||
| def test(data: ti.f32): | ||
| ti.cache_read_only(x) | ||
| assert x[None] == data |
There was a problem hiding this comment.
Force the x cache read only, to test global loading in codegen_cuda.cpp. Or, the x might be read the function in codegen_llvm.cpp
Co-authored-by: Yuanming Hu <[email protected]>
Hanke98
force-pushed
the
debug-cft-global-load
branch
from
8277c6f to
f771b3b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1905 #2065
Some mistakes were made in global loading on CUDA, which would lead to compilation error. I will point out the bug below.
And also, I added a new test case focusing on this problem in this pr
[Click here for the format server]