Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Remove data_type_short_name (use data_type_name instead) #2110

Merged
merged 1 commit into from
Dec 21, 2020
Merged

[misc] Remove data_type_short_name (use data_type_name instead) #2110

merged 1 commit into from
Dec 21, 2020

Conversation

yuanming-hu
Copy link
Member

@yuanming-hu yuanming-hu changed the title [misc] data_type_short_name is removed. Use data_type_name instead [misc] Remove data_type_short_name (use data_type_name instead) Dec 21, 2020
@yuanming-hu yuanming-hu merged commit 65dad7e into taichi-dev:master Dec 21, 2020
@yuanming-hu yuanming-hu deleted the remove-data-type-short-name branch December 21, 2020 02:19
archibate
archibate reviewed Dec 21, 2020
View reviewed changes
Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if data_type_name returns f32, i32.

@k-ye k-ye mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archibate archibate archibate left review comments

@taichi-gardener taichi-gardener Awaiting requested review from taichi-gardener

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuanming-hu @archibate