Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[async] Reduce the inlined edges size from 16 to 8 #2105

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Dec 20, 2020

Related issue = #742

On my end:

16:

...
[I 12/20/20 13:16:02.093] [state_flow_graph.cpp:taichi::lang::StateFlowGraph::benchmark_rebuild_graph@1504] nodes = 1001 total time 866.5100 ms (averaged so far 821.9 ms); per_node 865.6444 ns
[I 12/20/20 13:16:02.184] [state_flow_graph.cpp:taichi::lang::StateFlowGraph::benchmark_rebuild_graph@1504] nodes = 1001 total time 901.1000 ms (averaged so far 822.7 ms); per_node 900.1998 ns

8:

...
[I 12/20/20 13:16:40.974] [state_flow_graph.cpp:taichi::lang::StateFlowGraph::benchmark_rebuild_graph@1504] nodes = 1001 total time 710.3000 ms (averaged so far 721.0 ms); per_node 709.5904 ns
[I 12/20/20 13:16:41.044] [state_flow_graph.cpp:taichi::lang::StateFlowGraph::benchmark_rebuild_graph@1504] nodes = 1001 total time 701.7100 ms (averaged so far 720.8 ms); per_node 701.0090 ns

Note that averaged so far went down from 821 ms to 721 ms, so 12% faster..

[Click here for the format server]


Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! On my end, it goes down from 601 ns to 572 ns (5% faster) :-)

@yuanming-hu yuanming-hu merged commit 88fe632 into taichi-dev:master Dec 20, 2020
@k-ye k-ye mentioned this pull request Jan 5, 2021
@k-ye k-ye deleted the ref-small-ptr branch July 9, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants