[async] Compact AsyncState id for faster SFG rebuilding #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
commented
Nov 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #742
Before:
synchronize: 4.281rebuild_graphinoptimize_listgen: 0.799After:
synchronize: 3.996 (1.07x faster)rebuild_graphinoptimize_listgen: 0.714 (1.12x faster)Sorry about the potential conflict with #2070. Let's merge #2070 first and I'll fix the conflicts here on my own.
The design is probably not elegant yet at this point, but let's first get the desired performance and then aim for elegance.
[Click here for the format server]