[async] Faster SFG rebuilding #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
commented
Nov 29, 2020
| @@ -63,6 +66,13 @@ std::string AsyncState::name() const { | |||
| return prefix + "_" + type_name; | |||
| } | |||
|
|
|||
| std::size_t AsyncState::get_unique_id(void *ptr, AsyncState::Type type) { | |||
There was a problem hiding this comment.
This will be replaced with a more compact version (ranging in [0, ~1000)) in the next PR.
| @@ -121,6 +123,8 @@ struct AsyncState { | |||
| const SNode *snode() const { | |||
| return std::get<SNode *>(snode_or_global_tmp); | |||
| } | |||
|
|
|||
| static std::size_t get_unique_id(void *ptr, Type type); | |||
There was a problem hiding this comment.
This will be replaced in the next PR.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #742
This PR avoids the relatively expensive
std::variant<...>::operator==.We also adjust the order of
optimize_listgenanddemote_activationso that more list generations can be removed in the first iteration.Before:
synchronize: 5.935rebuild_graphinoptimize_listgen: 1.668After (1.38x faster):
synchronize: 4.281rebuild_graphinoptimize_listgen: 0.799[Click here for the format server]