[type] Use zext instruction to cast unsigned int #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
reviewed
Nov 28, 2020
yuanming-hu
approved these changes
Nov 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1905 #1996
In this pr, I try to determine which extension instruction should be used when casting integers. According to my understanding, we should use
zextfor unsigned int, andsextfor signed int.Please note that, the original goal of this pr is to determine the instruction for
CustomIntType. OneCustomIntTypeshould be loaded throughGlobalLoadStmtfirst before casting. After loading, theCustomIntTypewould be a "normal"integer type (the same type as its
ComputeType). That is to say, we can simply treat theCustomIntTypeand primitive integer type equally here.[Click here for the format server]