[type] Add CustomFloatType #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2062 +/- ##
==========================================
- Coverage 43.56% 43.53% -0.03%
==========================================
Files 45 45
Lines 6267 6264 -3
Branches 1110 1110
==========================================
- Hits 2730 2727 -3
Misses 3366 3366
Partials 171 171
Continue to review full report at Codecov.
|
yuanming-hu
commented
Nov 25, 2020
Comment on lines
-1129
to
-1158
| if (stmt->ptr->ret_type->as<PointerType>()->is_bit_pointer()) { | ||
| auto cit = stmt->ret_type->as<CustomIntType>(); | ||
| // 1. load bit pointer | ||
| llvm::Value *byte_ptr, *bit_offset; | ||
| read_bit_pointer(llvm_val[stmt->ptr], byte_ptr, bit_offset); | ||
|
|
||
| auto bit_level_container = builder->CreateLoad(builder->CreateBitCast( | ||
| byte_ptr, llvm_ptr_type(cit->get_physical_type()))); | ||
| // 2. bit shifting | ||
| // first left shift `physical_type - (offset + num_bits)` | ||
| // then right shift `physical_type - num_bits` | ||
| auto bit_end = builder->CreateAdd(bit_offset, | ||
| tlctx->get_constant(cit->get_num_bits())); | ||
| auto left = builder->CreateSub( | ||
| tlctx->get_constant(data_type_bits(cit->get_physical_type())), bit_end); | ||
| auto right = builder->CreateSub( | ||
| tlctx->get_constant(data_type_bits(cit->get_physical_type())), | ||
| tlctx->get_constant(cit->get_num_bits())); | ||
| left = builder->CreateIntCast(left, bit_level_container->getType(), false); | ||
| right = | ||
| builder->CreateIntCast(right, bit_level_container->getType(), false); | ||
| auto step1 = builder->CreateShl(bit_level_container, left); | ||
| llvm::Value *step2 = nullptr; | ||
| if (cit->get_is_signed()) | ||
| step2 = builder->CreateAShr(step1, right); | ||
| else | ||
| step2 = builder->CreateLShr(step1, right); | ||
|
|
||
| llvm_val[stmt] = builder->CreateIntCast( | ||
| step2, llvm_type(cit->get_compute_type()), cit->get_is_signed()); |
There was a problem hiding this comment.
This part is moved without change into load_as_custom_int.
Comment on lines
+1158
to
+1188
| llvm::Value *CodeGenLLVM::load_as_custom_int(Stmt *ptr, Type *load_type) { | ||
| auto *cit = load_type->as<CustomIntType>(); | ||
| // 1. load bit pointer | ||
| llvm::Value *byte_ptr, *bit_offset; | ||
| read_bit_pointer(llvm_val[ptr], byte_ptr, bit_offset); | ||
|
|
||
| auto bit_level_container = builder->CreateLoad(builder->CreateBitCast( | ||
| byte_ptr, llvm_ptr_type(cit->get_physical_type()))); | ||
| // 2. bit shifting | ||
| // first left shift `physical_type - (offset + num_bits)` | ||
| // then right shift `physical_type - num_bits` | ||
| auto bit_end = | ||
| builder->CreateAdd(bit_offset, tlctx->get_constant(cit->get_num_bits())); | ||
| auto left = builder->CreateSub( | ||
| tlctx->get_constant(data_type_bits(cit->get_physical_type())), bit_end); | ||
| auto right = builder->CreateSub( | ||
| tlctx->get_constant(data_type_bits(cit->get_physical_type())), | ||
| tlctx->get_constant(cit->get_num_bits())); | ||
| left = builder->CreateIntCast(left, bit_level_container->getType(), false); | ||
| right = builder->CreateIntCast(right, bit_level_container->getType(), false); | ||
| auto step1 = builder->CreateShl(bit_level_container, left); | ||
| llvm::Value *step2 = nullptr; | ||
|
|
||
| if (cit->get_is_signed()) | ||
| step2 = builder->CreateAShr(step1, right); | ||
| else | ||
| step2 = builder->CreateLShr(step1, right); | ||
|
|
||
| return builder->CreateIntCast(step2, llvm_type(cit->get_compute_type()), | ||
| cit->get_is_signed()); | ||
| } |
There was a problem hiding this comment.
Extracted from CodeGenLLVM::visit(GlobalLoadStmt *stmt).
TH3CHARLie
approved these changes
Nov 26, 2020
Hanke98
approved these changes
Nov 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1905
Sorry about the large changes.
CustomFloatTypeCustomFloatType(atomid_addwill be done later.)KernelReturnStmt/ArgLoadStmtctor no longer takes data type. Their return data types are inferred bytype_checkget_compute_typeis now part ofTypeAPI. Overriden in derived classesCustomFloatType,CustomIntType,PrimitiveType.GlobalPtrStmtis now a pointer type (used to be only the pointee type)CustomFloat/IntTypeis_real(DataType)GlobalStoreStmtno longer has a return data type[Click here for the format server]