-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt] [async] Fix constant folding in async mode #2034
Conversation
TI_TRACE("Synchronizing SFG of {} nodes ({} pending)", sfg->size(), | ||
sfg->num_pending_tasks()); | ||
debug_sfg("initial"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off-topic change: num_pending_tasks()
matches the following Ended up with {} nodes
better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
I'll merge to see if this fixes problems on my end.
Codecov Report
@@ Coverage Diff @@
## master #2034 +/- ##
=======================================
Coverage 43.54% 43.54%
=======================================
Files 45 45
Lines 6267 6267
Branches 1110 1110
=======================================
Hits 2729 2729
Misses 3366 3366
Partials 172 172 Continue to review full report at Codecov.
|
Related issue = #954 #2032
Kernel::Kernel()
does not support multi-threads unless we lock the following part with a mutex:This PR simply locks
get_jit_evaluator_kernel()
monolithically to prevent two threads from callingKernel::Kernel()
concurrently.[Click here for the format server]