[type] Support bit-level read and write in Python-scope #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
==========================================
+ Coverage 43.52% 43.54% +0.02%
==========================================
Files 45 45
Lines 6270 6267 -3
Branches 1110 1110
==========================================
Hits 2729 2729
+ Misses 3369 3366 -3
Partials 172 172
Continue to review full report at Codecov.
|
yuanming-hu
approved these changes
Nov 7, 2020
taichi/program/kernel.cpp
Outdated
Comment on lines
304
to
308
| } else if (auto cit = dt->cast<CustomIntType>()) { | ||
| if (cit->get_is_signed()) | ||
| return (int64)get_current_program().fetch_result<int32>(i); | ||
| else | ||
| return (uint64)get_current_program().fetch_result<uint32>(i); |
There was a problem hiding this comment.
We are good for now, but sometime in the future we may need to use i64.
taichi/llvm/llvm_context.cpp
Outdated
Comment on lines
110
to
111
| } else if (dt->is<CustomIntType>()) { | ||
| return llvm::Type::getInt32Ty(*ctx); |
There was a problem hiding this comment.
I don't think this branch belongs here. CustomIntType should not be exposed to LLVM. It makes more sense to do the branching on the caller side of this function.
Co-authored-by: Yuanming Hu <[email protected]>
TH3CHARLie
approved these changes
Nov 7, 2020
There was a problem hiding this comment.
Looks good and I verified @yuanming-hu's suggestions have been applied.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1905 #1996
In this pr, we tried to support reading/writing
bit_structin python scope.The key change is : support
CustomIntTypeinget_data_type,get_ret_intandget_ret_int[Click here for the format server]