Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] Test OpenGL using GitHub actions #2014

Merged
merged 5 commits into from
Nov 11, 2020

Conversation

yuanming-hu
Copy link
Member

@yuanming-hu yuanming-hu changed the title [misc] Test OpenGL on buildbot [workflow] Test OpenGL on buildbot Oct 31, 2020
@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #2014 (978d32e) into master (380f116) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
+ Coverage   43.54%   43.56%   +0.02%     
==========================================
  Files          45       45              
  Lines        6267     6264       -3     
  Branches     1110     1109       -1     
==========================================
  Hits         2729     2729              
+ Misses       3366     3363       -3     
  Partials      172      172              
Impacted Files Coverage Δ
python/taichi/diagnose.py 0.00% <0.00%> (ø)
python/taichi/lang/__init__.py 40.57% <0.00%> (+0.16%) ⬆️
python/taichi/misc/util.py 20.54% <0.00%> (+0.21%) ⬆️
python/taichi/lang/snode.py 68.10% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe152f...2005a98. Read the comment docs.

@yuanming-hu
Copy link
Member Author

@archibate Everything is now set up on zhen :-) Please fix #1931 before merging this PR. The buildbot fails because of the following error:

=========================== short test summary info ============================
FAILED tests/python/test_bit_operations.py::test_bit_shr[opengl] - RuntimeErr...
======= 1 failed, 848 passed, 113 skipped, 2 rerun in 844.81s (0:14:04) ========

@yuanming-hu yuanming-hu changed the title [workflow] Test OpenGL on buildbot [workflow] Test OpenGL using GitHub actions Nov 1, 2020
Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's exclude opengl from test_bit_shr for fix #1931 then, it's not trivial to introduce unsigned types to OpenGL and I believe most people will just make use of bit_sar.

.github/workflows/persubmit.yml Show resolved Hide resolved
@yuanming-hu
Copy link
Member Author

Let's exclude opengl from test_bit_shr for fix #1931 then, it's not trivial to introduce unsigned types to OpenGL and I believe most people will just make use of bit_sar.

Any insight on why unsigned types for OpenGL is more non-trivial than the signed ones? I think adding unsigned types there would be very meaningful.

@yuanming-hu yuanming-hu merged commit 15ac644 into taichi-dev:master Nov 11, 2020
@yuanming-hu yuanming-hu deleted the zhenopengl branch November 11, 2020 20:21
@yuanming-hu yuanming-hu mentioned this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants