-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workflow] Test OpenGL using GitHub actions #2014
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
==========================================
+ Coverage 43.54% 43.56% +0.02%
==========================================
Files 45 45
Lines 6267 6264 -3
Branches 1110 1109 -1
==========================================
Hits 2729 2729
+ Misses 3366 3363 -3
Partials 172 172
Continue to review full report at Codecov.
|
@archibate Everything is now set up on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's exclude opengl
from test_bit_shr for fix #1931 then, it's not trivial to introduce unsigned types to OpenGL and I believe most people will just make use of bit_sar.
Any insight on why unsigned types for OpenGL is more non-trivial than the signed ones? I think adding unsigned types there would be very meaningful. |
[Click here for the format server]