[metal] Refactor sparse shader impl in prep for pointer SNode #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-ye
commented
Oct 25, 2020
k-ye
commented
Oct 25, 2020
| ElementCoords coords; | ||
| // Memory offset from a given address. | ||
| // * If in_root_buffer() is true, this is from the root buffer address. | ||
| // * O.W. this is from the |id|-th NodeManager's |elem_idx|-th element. |
There was a problem hiding this comment.
The O.W. part is not implemented in this PR yet (therefore the placeholder in_root_buffer() always returns true at this point).
Codecov Report
@@ Coverage Diff @@
## master #1994 +/- ##
==========================================
+ Coverage 43.41% 43.50% +0.09%
==========================================
Files 45 45
Lines 6268 6266 -2
Branches 1109 1109
==========================================
+ Hits 2721 2726 +5
+ Misses 3373 3367 -6
+ Partials 174 173 -1
Continue to review full report at Codecov.
|
Co-authored-by: Yuanming Hu <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR contains mostly refactors and tweaks needed for
pointer.NodeManagerData:: ElemIndexa strong type instead of an alias forint32_t. This is because we have to shift the rawint32_tindex allocated fromNodeManagerData's lists (akaListManagers), in order for the spinning memory allocation ([Metal] Support dynamic memory allocation on GPU #1174) to work. Using a plainint32_tis dangerous, as I have forgotten about the shift in allocation or recycle previously...ListgenElement::coordsinto a separate type:ElementCoords. The generated struct-for kernel only needs to know the coordinates, but not other info insideListgenElement(which will be expanded later).Related issue = #1740, #1174
[Click here for the format server]