[Type] [refactor] Remove LegacyVectorType #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanke98
commented
Oct 17, 2020
| @@ -36,4 +36,16 @@ Type *TypeFactory::get_pointer_type(Type *element) { | |||
| TypeFactory::TypeFactory() { | |||
| } | |||
|
|
|||
| DataType TypeFactory::create_vector_or_scalar_type(int width, | |||
| DataType element, | |||
| bool element_is_pointer) { | |||
There was a problem hiding this comment.
This is the core change, we use this function to replace the LegacyVectorType
Hanke98
requested review from
taichi-gardener and
yuanming-hu
and removed request for
taichi-gardener
Codecov Report
@@ Coverage Diff @@
## master #1967 +/- ##
=======================================
Coverage 43.64% 43.64%
=======================================
Files 45 45
Lines 6225 6225
Branches 1106 1106
=======================================
Hits 2717 2717
Misses 3334 3334
Partials 174 174 Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1905
In this pr, we remove the class
LegacyVectorTypeand use a static functionTypeFactory::create_vector_or_scalar_typeinstead.[Click here for the format server]