Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] [gui] Support ti.GUI(fast_gui=True) on Win32 #1953

Merged
merged 7 commits into from
Oct 17, 2020

Conversation

archibate
Copy link
Collaborator

Related issue = #1922

[Click here for the format server]


With no way to confirm if this works as I don't have a win dev env..

@archibate archibate requested a review from k-ye October 14, 2020 14:43
@archibate archibate changed the title [win] [gui] Support ti.GUI(fast_gui=True) on Win32 [windows] [gui] Support ti.GUI(fast_gui=True) on Win32 Oct 14, 2020
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #1953 into master will decrease coverage by 0.00%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1953      +/-   ##
==========================================
- Coverage   43.65%   43.65%   -0.01%     
==========================================
  Files          45       45              
  Lines        6226     6222       -4     
  Branches     1107     1106       -1     
==========================================
- Hits         2718     2716       -2     
+ Misses       3334     3332       -2     
  Partials      174      174              
Impacted Files Coverage Δ
python/taichi/lang/meta.py 64.00% <0.00%> (+1.17%) ⬆️
python/taichi/lang/ndrange.py 73.52% <0.00%> (ø)
python/taichi/lang/impl.py 66.75% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41598a...d8e0be6. Read the comment docs.

@archibate archibate merged commit 1c1edb7 into taichi-dev:master Oct 17, 2020
@yuanming-hu yuanming-hu mentioned this pull request Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants