Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Add a link to TaichiHub playground in README.md #1933

Merged
merged 4 commits into from
Oct 10, 2020

Conversation

archibate
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #1933 into master will increase coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1933      +/-   ##
==========================================
+ Coverage   42.80%   43.72%   +0.92%     
==========================================
  Files          45       45              
  Lines        6413     6207     -206     
  Branches     1101     1103       +2     
==========================================
- Hits         2745     2714      -31     
+ Misses       3498     3322     -176     
- Partials      170      171       +1     
Impacted Files Coverage Δ
...aichi-dev/taichi/python/taichi/lang/ast_checker.py 70.58% <0.00%> (-1.64%) ⬇️
...s/build/taichi-dev/taichi/python/taichi/testing.py 75.00% <0.00%> (-0.72%) ⬇️
...ild/taichi-dev/taichi/python/taichi/lang/linalg.py 89.33% <0.00%> (-0.67%) ⬇️
...build/taichi-dev/taichi/python/taichi/lang/meta.py 64.38% <0.00%> (-0.49%) ⬇️
...d/taichi-dev/taichi/python/taichi/lang/__init__.py 40.45% <0.00%> (-0.33%) ⬇️
...build/taichi-dev/taichi/python/taichi/misc/util.py 18.27% <0.00%> (-0.24%) ⬇️
...build/taichi-dev/taichi/python/taichi/misc/task.py 0.00% <0.00%> (ø)
.../taichi-dev/taichi/python/taichi/tools/patterns.py 0.00% <0.00%> (ø)
.../build/taichi-dev/taichi/python/taichi/misc/gui.py 8.68% <0.00%> (+0.07%) ⬆️
...ild/taichi-dev/taichi/python/taichi/lang/kernel.py 71.39% <0.00%> (+0.13%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfed2d9...d048ab1. Read the comment docs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM. I also made some minor updates surrounding this PR. Thanks.

@yuanming-hu yuanming-hu changed the title [misc] Add link to TaichiHub playground in README.md [misc] Add a link to TaichiHub playground in README.md Oct 10, 2020
@yuanming-hu yuanming-hu merged commit 4363ab8 into master Oct 10, 2020
@yuanming-hu yuanming-hu deleted the readme-playground branch October 10, 2020 20:57
@yuanming-hu yuanming-hu mentioned this pull request Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants