[ir] Remove the usage of kernel from type_check() pass #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-ye
requested review from
yuanming-hu,
taichi-gardener,
xumingkuan and
archibate
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
==========================================
+ Coverage 64.23% 64.26% +0.02%
==========================================
Files 19 19
Lines 3722 3725 +3
Branches 705 705
==========================================
+ Hits 2391 2394 +3
Misses 1204 1204
Partials 127 127
Continue to review full report at Codecov.
|
xumingkuan
approved these changes
Sep 6, 2020
| @@ -34,9 +34,11 @@ class ConstantFold : public BasicStmtVisitor { | |||
| } | |||
There was a problem hiding this comment.
Off-topic: lines 10-11 are redundant in this file.
taichi/python/export_lang.cpp
Outdated
| @@ -346,8 +346,9 @@ void export_lang(py::module &m) { | |||
| current_ast_builder().insert(Stmt::make<FrontendBreakStmt>()); | |||
| }); | |||
|
|
|||
| m.def("create_kernel_return", [&](const Expr &value) { | |||
| current_ast_builder().insert(Stmt::make<FrontendKernelReturnStmt>(value)); | |||
| m.def("create_kernel_return", [&](const Expr &value, DataType dt) { | |||
There was a problem hiding this comment.
nit: Shall we use DataType dt or const DataType & (which is used in make_arg_load_expr)?
There was a problem hiding this comment.
Ack, switched to const DataType& (I tried to use DataType for make_arg_load_expr, but bumped into funny rvalue reference issues..)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we know the kernel args and return types when constructing these arg load/kernel return stmts, we don't have to re-infer them inside
type_check(). This PR removes the necessity of kernel intype_check(config is still not handled), so that IR is a bit more decoupled from Kernel.Related issue = #689
[Click here for the format server]