[ir] [autodiff] Initialize ADStack with a zero #1791
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1791 +/- ##
=======================================
Coverage 61.74% 61.74%
=======================================
Files 19 19
Lines 3850 3850
Branches 691 691
=======================================
Hits 2377 2377
Misses 1348 1348
Partials 125 125 Continue to review full report at Codecov.
|
archibate
approved these changes
Aug 28, 2020
taichi/transforms/auto_diff.cpp
Outdated
Comment on lines
210
to
211
| // Note that unlike AllocStmt, StackAllocaStmt does NOT have an 0 as | ||
| // initial value. Therefore here we push an initial 0 value. |
There was a problem hiding this comment.
Suggested change
| // Note that unlike AllocStmt, StackAllocaStmt does NOT have an 0 as | |
| // initial value. Therefore here we push an initial 0 value. | |
| // Note that unlike AllocaStmt, StackAllocaStmt does NOT have an 0 as | |
| // initial value. Therefore here we push an initial 0 value. |
How about enforce StackAllocaStmt to be zero initialized over backends like CC did in #1752?
There was a problem hiding this comment.
There's nothing needed to be done in the backends. The instruction pushing a zero is emitted into the IR and StackAllocaStmt only needs to create an empty stack.
|
Merging this for #1752. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = close #1781
[Click here for the format server]