Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ir] Restore verification for OffloadedStmt #1790

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

xumingkuan
Copy link
Contributor

@xumingkuan xumingkuan commented Aug 27, 2020

Related issue = #

(Possibly a bug in async?)

[Click here for the format server]


@yuanming-hu
Copy link
Member

Actually, I disabled that intentionally so that the verification pass doesn't crash on async mode... I don't remember why it crashes in async mode, but maybe you have more ideas than I do :-)

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1790 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1790      +/-   ##
==========================================
- Coverage   42.52%   42.45%   -0.07%     
==========================================
  Files          44       44              
  Lines        6192     6202      +10     
  Branches     1072     1073       +1     
==========================================
  Hits         2633     2633              
- Misses       3405     3414       +9     
- Partials      154      155       +1     
Impacted Files Coverage Δ
python/taichi/testing.py 75.75% <0.00%> (-2.37%) ⬇️
python/taichi/core/util.py 0.37% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db426fe...f123c84. Read the comment docs.

@xumingkuan xumingkuan requested a review from yuanming-hu August 28, 2020 15:28
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM. Thanks!

@yuanming-hu yuanming-hu merged commit 9f182b1 into taichi-dev:master Aug 28, 2020
@xumingkuan xumingkuan deleted the verify-offload branch August 29, 2020 09:56
@yuanming-hu yuanming-hu mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants