[Doc] Separate arithmetics.rst from syntax.rst and fill it with more details #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1761 +/- ##
==========================================
- Coverage 43.19% 42.75% -0.44%
==========================================
Files 44 44
Lines 6075 6132 +57
Branches 1050 1070 +20
==========================================
- Hits 2624 2622 -2
- Misses 3297 3356 +59
Partials 154 154
Continue to review full report at Codecov.
|
isdanni
reviewed
Aug 25, 2020
Comment on lines
+111
to
+119
| Builtin-alike functions | ||
| *********************** | ||
|
|
||
| .. function:: abs(x) | ||
| .. function:: max(x, y, ...) | ||
| .. function:: min(x, y, ...) | ||
| .. function:: pow(x, y) | ||
|
|
||
| Same as ``x ** y``. |
There was a problem hiding this comment.
I'm kinda confused here. What does "Builtin-alike" mean? 🤔 Would just "built-in" be enough?
There was a problem hiding this comment.
Since abs and max are builtin functions, but they are replaced by ti.ti_abs and ti.ti_max by @ti.kernel, which is our functions. They just share the same interface with the Python built-in ones.
isdanni
approved these changes
Aug 26, 2020
ArkhamWJZ
approved these changes
Aug 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #
[Click here for the format server]
So that
syntax.rstcan focus on explaining Taichi kernels and functions.I don't rename
syntax.rstin afraid of broken links and spoil translators' work insyntax.po.