Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Better clarify the difference between two profilers #1759

Merged
merged 6 commits into from
Aug 28, 2020

Conversation

archibate
Copy link
Collaborator

This reverts commit 23ef1fc.
This reverts commit b81725f.
@archibate archibate force-pushed the better-clarify-profiler branch from 4469b43 to 7ec2bd9 Compare August 24, 2020 05:30
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1759 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
- Coverage   42.50%   42.45%   -0.06%     
==========================================
  Files          44       44              
  Lines        6194     6202       +8     
  Branches     1073     1073              
==========================================
  Hits         2633     2633              
- Misses       3406     3414       +8     
  Partials      155      155              
Impacted Files Coverage Δ
python/taichi/core/util.py 0.37% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e43b5...ac589cd. Read the comment docs.

@archibate archibate requested a review from isdanni August 26, 2020 07:11
Copy link
Contributor

@isdanni isdanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only a few nits :)

docs/profiler.rst Outdated Show resolved Hide resolved
docs/profiler.rst Outdated Show resolved Hide resolved
@archibate archibate merged commit 7fa0d9d into taichi-dev:master Aug 28, 2020
@yuanming-hu yuanming-hu mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants