Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add performance.rst introducing the 'ti.block_dim' API #1691

Merged
merged 11 commits into from
Sep 3, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Aug 13, 2020

Related issue = https://forum.taichi.graphics/t/how-to-prevent-3d-mpm-from-becoming-memory-bound/1086/3

[Click here for the format server]


Amazing! ti.block_dim(n_grid) yields ~3x performance boost in mpm3d.py on my end! So I'd like share this with our users :)

@archibate archibate requested review from yuanming-hu, Rullec, KLozes, k-ye and taichi-gardener and removed request for taichi-gardener August 13, 2020 14:03
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #1691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1691   +/-   ##
=======================================
  Coverage   64.21%   64.21%           
=======================================
  Files          19       19           
  Lines        3714     3714           
  Branches      701      701           
=======================================
  Hits         2385     2385           
  Misses       1202     1202           
  Partials      127      127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee1975...d2907fd. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This will be very helpful. Please fix the minor issues.

taichi/backends/opengl/codegen_opengl.cpp Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I took another pass. This mostly looks good to me now.

docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
docs/performance.rst Outdated Show resolved Hide resolved
@archibate archibate merged commit ded4c17 into taichi-dev:master Sep 3, 2020
@yuanming-hu yuanming-hu mentioned this pull request Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants