Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cc] Add ti.cfg.cc_compile_cmd and ti.cfg.cc_link_cmd #1645

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

archibate
Copy link
Collaborator

Related issue = #1332 #1644

[Click here for the format server]


  1. ti.cfg.cc_compile_cmd = "gcc -c -o '{}' '{}' -O3".
  2. ti.init(cc_compile_cmd="gcc -c -o '{}' '{}' -O3").
  3. export TI_CC_COMPILE_CMD="gcc -c -o '{}' '{}' -O3".

@k-ye Could you confirm it works on your osx machine by using the correct compile_cmd?
Could you add a #ifdef TI_PLATFORM_OSX guard to add the most commonly used compiler on OS X?

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #1645 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1645   +/-   ##
=======================================
  Coverage   44.40%   44.40%           
=======================================
  Files          41       41           
  Lines        5876     5876           
  Branches     1022     1022           
=======================================
  Hits         2609     2609           
  Misses       3118     3118           
  Partials      149      149           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29071b3...1292472. Read the comment docs.

@archibate
Copy link
Collaborator Author

@yuanming-hu Did you forget to release v0.7.25?

@archibate
Copy link
Collaborator Author

Hi, I'm merging this for now given that v0.7.25 is all set. FF2 revert me if you find any fatal drawback.

@archibate archibate merged commit bf403b5 into taichi-dev:master Aug 10, 2020
@yuanming-hu yuanming-hu mentioned this pull request Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants