[GUI] Support slider, label and button as widgets #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-ye
reviewed
Jul 14, 2020
| gui->slider(text, *val_ptr, minimum, maximum, step); | ||
| return gui->widget_values.size() - 1; | ||
| }) | ||
| .def("make_label", |
There was a problem hiding this comment.
I wonder why a label must have a floating value? And there's no way to change its text?
There was a problem hiding this comment.
Please run my example and use key 'a' and 'd'.
There was a problem hiding this comment.
I'm not saying the printed text as a whole cannot be changed. Instead, it seems that only the floating value part could change? But now I looked at Label, I guess this is a restriction from the GUI system itself..
There was a problem hiding this comment.
I think people could use gui.text for more flexibility, given that the label is provided by the legacy C++ part, let's try improve it iapr, instead of itpr.
k-ye
approved these changes
Jul 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = close #484
[Click here for the format server]
Btw, I found the slider circle is not shown, is this intentional?