Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Partially support assertions and access out-of-bound checks on CUDA #1488

Merged
merged 7 commits into from
Jul 14, 2020

Conversation

yuanming-hu
Copy link
Member

Note that since we can't call vsnprintf on CUDA, access out of bound check messages would be unformatted: Accessing (%d, %d) out of bound...

[Click here for the format server]


Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMig + nits.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #1488 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
+ Coverage   66.88%   66.94%   +0.05%     
==========================================
  Files          38       38              
  Lines        5433     5424       -9     
  Branches      956      956              
==========================================
- Hits         3634     3631       -3     
+ Misses       1636     1630       -6     
  Partials      163      163              
Impacted Files Coverage Δ
python/taichi/lang/ops.py 93.12% <ø> (+0.27%) ⬆️
python/taichi/lang/util.py 64.70% <ø> (-0.21%) ⬇️
python/taichi/misc/error.py 14.28% <ø> (ø)
python/taichi/__init__.py 92.00% <100.00%> (+0.33%) ⬆️
python/taichi/lang/__init__.py 78.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63714c...ddb572d. Read the comment docs.

@yuanming-hu yuanming-hu merged commit 881500b into taichi-dev:master Jul 14, 2020
@FantasyVR FantasyVR mentioned this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants