Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Add matrix method documentation including normalized() #1485

Merged
merged 3 commits into from
Jul 14, 2020
Merged

[doc] Add matrix method documentation including normalized() #1485

merged 3 commits into from
Jul 14, 2020
+80 −32

Conversation

archibate
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Jul 13, 2020 •
edited
Loading

Codecov Report

Merging #1485 into master will increase coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1485      +/-   ##
==========================================
+ Coverage   85.31%   86.14%   +0.82%     
==========================================
  Files          20       19       -1     
  Lines        3589     3543      -46     
  Branches      638      631       -7     
==========================================
- Hits         3062     3052      -10     
+ Misses        399      363      -36     
  Partials      128      128
Impacted Files Coverage Δ
python/taichi/lang/__init__.py 78.60% <ø> (-0.06%) ⬇️
python/taichi/lang/ops.py 93.12% <ø> (+0.27%) ⬆️
python/taichi/lang/util.py 64.70% <ø> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63714c...e5286d0. Read the comment docs.

k-ye
k-ye approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@archibate archibate added the LGTM label Jul 14, 2020
@archibate archibate merged commit c8b4f43 into taichi-dev:master Jul 14, 2020
@FantasyVR FantasyVR mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye

@yuanming-hu yuanming-hu

@KLozes KLozes

@taichi-gardener taichi-gardener

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@archibate @k-ye