[test] [bug] Fix master test failure by #1437 #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archibate
commented
Jul 11, 2020
| @ti.must_throw(AssertionError) | ||
| def test_numpy_3d(): | ||
| @ti.must_throw(IndexError) | ||
| def test_numpy_3d_error(): |
There was a problem hiding this comment.
I'm wondering who wrote this test... Its name overrides the previous one.
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
=========================================
Coverage ? 66.98%
=========================================
Files ? 38
Lines ? 5410
Branches ? 951
=========================================
Hits ? 3624
Misses ? 1624
Partials ? 162 Continue to review full report at Codecov.
|
|
Merging this to prevent future failure, let's talk about ext_arr iapr. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #
[Click here for the format server]
Sorry about breaking master test :(
But what's the point of using
np.ndarrayin Taichi-scope?IMO
ti.ext_arr()is being edged and can be easily buggy.. e.g.: https://forum.taichi.graphics/t/hw0-5-implicit-euler-method-on-mass-spring-system/961/13If we don't maintain
ti.ext_arr(), how about just deprecate it and do some walk around forto_numpy?