[Bug] [ir] Fix compilation crash when there's a cross-offload global atomic operation #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1392 +/- ##
==========================================
+ Coverage 85.59% 85.62% +0.03%
==========================================
Files 19 19
Lines 3394 3388 -6
Branches 622 622
==========================================
- Hits 2905 2901 -4
+ Misses 359 358 -1
+ Partials 130 129 -1
Continue to review full report at Codecov.
|
archibate
approved these changes
Jul 4, 2020
There was a problem hiding this comment.
LGTM (with no knowledge about the optimization engine, just confirmed it's working in any combination).
Btw, can we have an option ti.core.toggle_all_optimization(False) to turn off all optimization so that we can easier confirm a bug & make compile faster when test?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = fix #1390
Global atomic op should call the generic visitor instead of the overloaded one.
Added a test that fails before this PR.
[Click here for the format server]