-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Update documentaion on meta programming for #1374 #1389
Merged
archibate
merged 14 commits into
taichi-dev:master
from
archibate:doc-deprecate-data_type-use-dtype-instead
Jul 17, 2020
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4e9f1d5
[Refactor] [lang] x.data_type() is deprecated, use x.dtype instead
archibate 356999e
improve doc
archibate 987b738
did deprecate
archibate f63b83c
fix
archibate 0fd86bb
merge master
archibate 0f34e4f
[skip ci] enforce code format
taichi-gardener 30d8f1c
[skip ci] Update docs/vector.rst
archibate 741c153
[skip ci] Merge branch 'master' into deprecate-data_type-use-dtype-in…
archibate 0d3efb6
revert doc
archibate 38cf03e
Revert "revert doc"
archibate 9f434eb
Merge branch 'master' into doc-deprecate-data_type-use-dtype-instead
archibate 6c1d48f
[skip ci] Apply suggestions from code review
archibate de62ab5
[skip ci] Update docs/meta.rst
archibate 47cf398
Update docs/meta.rst
archibate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we are mixing 2-space and 4-space identation... Maybe we should somehow enforce PEP8 for all the Python code in the doc? I don't have a clear idea how that can be done automatically :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, e.g.:
vs
Is that possible to let
ti format
take care of that too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably can, but I don't think that would be easy. We will need to write an
rst
parster that extract the code, format usingyapf
, and the put it back...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, my idea is: not only parse the
code-block
, but parse the wholerst
, e.g.:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably need a different tool. I don't think yapf can correctly handle
rst
...