[bug] [opt] Fix CFG ignoring local atomics after lower_access #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
=======================================
Coverage 85.60% 85.60%
=======================================
Files 19 19
Lines 3375 3375
Branches 625 625
=======================================
Hits 2889 2889
Misses 356 356
Partials 130 130 Continue to review full report at Codecov.
|
|
@yuanming-hu Could you please take a look at this? I need it for my next PR. Thanks! |
yuanming-hu
approved these changes
Jul 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = N/A
stmt->is<AllocaStmt>() || stmt->is<LocalStoreStmt>()is not enough -- it didn't cover the local atomics' case.Also considers range_for and struct_for as parallel for-loops before the
offloadpass.[Click here for the format server]