Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux] Remove glibc2.27 dependency ([email protected]) #1342

Merged
merged 2 commits into from
Jun 27, 2020

Conversation

yuanming-hu
Copy link
Member

@yuanming-hu yuanming-hu commented Jun 26, 2020

Related issue = #1313

Since the dependency is not introduced in Taichi, I had to use this trick: https://stackoverflow.com/questions/8823267/linking-against-older-symbol-version-in-a-so-file

[Click here for the format server]


@yuanming-hu yuanming-hu requested a review from archibate June 26, 2020 22:16
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #1342 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1342   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files          37       37           
  Lines        5143     5143           
  Branches      931      931           
=======================================
  Hits         3419     3419           
  Misses       1562     1562           
  Partials      162      162           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a82113...b07ac8e. Read the comment docs.

Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@yuanming-hu yuanming-hu merged commit 7862c09 into taichi-dev:master Jun 27, 2020
@yuanming-hu yuanming-hu mentioned this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants