Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] [metal] Add a TaichiKernelAttribs struct #1341

Merged
merged 2 commits into from
Jun 28, 2020
Merged

[refactor] [metal] Add a TaichiKernelAttribs struct #1341

merged 2 commits into from
Jun 28, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Jun 26, 2020

Added TaichiKernelAttribs and UsedFeatures according to @archibate 's suggestion.

Related issue = ##1310 (comment)

[Click here for the format server]

@k-ye k-ye requested a review from archibate June 26, 2020 14:20
@codecov
Copy link

codecov bot commented Jun 26, 2020 •
edited
Loading

Codecov Report

Merging #1341 into master will increase coverage by 0.04%.
The diff coverage is 91.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   85.50%   85.54%   +0.04%     
==========================================
  Files          19       19              
  Lines        3352     3362      +10     
  Branches      622      622              
==========================================
+ Hits         2866     2876      +10     
  Misses        356      356              
  Partials      130      130
Impacted Files Coverage Δ
python/taichi/lang/transformer.py 93.63% <ø> (ø)
python/taichi/lang/matrix.py 90.70% <88.88%> (+0.03%) ⬆️
python/taichi/lang/expr.py 89.82% <91.66%> (ø)
python/taichi/lang/snode.py 87.12% <92.85%> (+1.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 477b1e1...09f5e0f. Read the comment docs.

yuanming-hu
yuanming-hu approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

archibate
archibate approved these changes Jun 28, 2020
View reviewed changes
Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTMig.

@k-ye k-ye merged commit 5a5ce2e into taichi-dev:master Jun 28, 2020
@k-ye k-ye deleted the tik-attribs branch June 28, 2020 07:22
@FantasyVR FantasyVR mentioned this pull request Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archibate archibate archibate approved these changes

@yuanming-hu yuanming-hu yuanming-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-ye @yuanming-hu @archibate