[Sparse] [lang] Add ti.activate support #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
=======================================
Coverage 85.48% 85.49%
=======================================
Files 19 19
Lines 3375 3377 +2
Branches 630 630
=======================================
+ Hits 2885 2887 +2
Misses 358 358
Partials 132 132
Continue to review full report at Codecov.
|
k-ye
approved these changes
Jun 26, 2020
| n = 16 | ||
|
|
||
| ptr = ti.root.pointer(ti.i, n) | ||
| ptr.dense(ti.i, n).place(x) |
There was a problem hiding this comment.
nit: Actually WDYT if we remove this dense layer, i.e. ptr.place(x)? If so, s[None] should be exactly how many elements in x that are activated. It makes the test more obvious?
There was a problem hiding this comment.
Maybe we want to test the behavior of multi-layer sparse, i.e. make OpenGL fake dynamic support fail to test.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1256 (comment)
[Click here for the format server]
Would you write a test for me? I'm not super familiar with sparse.