Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Deprecate ti.raw_pow #1330

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Jun 25, 2020

Related issue = #1188 (comment)

[Click here for the format server]


I removed ti.raw_pow and use pow directly instead, but seems the issue still exists? @k-ye Could you confirm that on your end?

@k-ye
Copy link
Member

k-ye commented Jun 25, 2020

Thanks!

As I mentioned, the real problem #1329 is that random() is not handled properly (I think). #1188 only exaggerated the problem a bit.

@archibate archibate requested a review from yuanming-hu June 25, 2020 15:24
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #1330 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
+ Coverage   66.40%   66.41%   +0.01%     
==========================================
  Files          37       37              
  Lines        5155     5133      -22     
  Branches      939      931       -8     
==========================================
- Hits         3423     3409      -14     
+ Misses       1568     1562       -6     
+ Partials      164      162       -2     
Impacted Files Coverage Δ
python/taichi/lang/expr.py 89.82% <100.00%> (+0.06%) ⬆️
python/taichi/lang/ops.py 93.70% <100.00%> (+0.87%) ⬆️
python/taichi/lang/util.py 64.07% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13462ff...7c18474. Read the comment docs.

Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants