Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Fix a bug in util.py #1327

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Conversation

Rullec
Copy link
Contributor

@Rullec Rullec commented Jun 25, 2020

Hi all,
When I am testing ti.info, I found that there is a literally typo in our util.py.
It will crash all logging APIs. :(

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@Rullec
Copy link
Contributor Author

Rullec commented Jun 25, 2020

Thx!

With pleasure :)

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #1327 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
+ Coverage   85.35%   85.48%   +0.12%     
==========================================
  Files          19       19              
  Lines        3374     3375       +1     
  Branches      630      630              
==========================================
+ Hits         2880     2885       +5     
+ Misses        362      358       -4     
  Partials      132      132              
Impacted Files Coverage Δ
python/taichi/lang/expr.py 89.82% <100.00%> (+0.06%) ⬆️
python/taichi/lang/util.py 64.07% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13462ff...a83bc03. Read the comment docs.

@k-ye k-ye merged commit eb83662 into taichi-dev:master Jun 25, 2020
@yuanming-hu yuanming-hu mentioned this pull request Jun 28, 2020
@Rullec Rullec deleted the fix_a_bug_in_get_logging branch July 26, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants