Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Fix compilation warning #1320

Merged
merged 1 commit into from
Jun 24, 2020
Merged

[misc] Fix compilation warning #1320

merged 1 commit into from
Jun 24, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Jun 24, 2020

@k-ye k-ye requested review from archibate and xumingkuan June 24, 2020 11:15
@k-ye
Copy link
Member Author

k-ye commented Jun 24, 2020

I believe the CI just went flaky for this PR... Merging

@k-ye k-ye merged commit 4a0ec07 into taichi-dev:master Jun 24, 2020
@k-ye k-ye deleted the warn branch June 24, 2020 14:55
@xumingkuan
Copy link
Contributor

So implicitly calling functions inherited from the base class will cause a warning when compiled by clang in Linux?

@k-ye
Copy link
Member Author

k-ye commented Jun 25, 2020

So implicitly calling functions inherited from the base class will cause a warning when compiled by clang in Linux?

clang (the default compiler on Mac) seems to have a slightly different C++ name lookup rules from gcc. See https://stackoverflow.com/a/6727196/12003165

Rullec pushed a commit to Rullec/taichi that referenced this pull request Jun 26, 2020
@k-ye @Rullec
[misc] Fix compilation warning (taichi-dev#1320)
3e9384c
@yuanming-hu yuanming-hu mentioned this pull request Jun 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archibate archibate archibate approved these changes

@xumingkuan xumingkuan Awaiting requested review from xumingkuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-ye @xumingkuan @archibate