-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Fix some typos in our document export_results.rst #1312
[doc] Fix some typos in our document export_results.rst #1312
Conversation
Thanks, could you also fix the ones in offset.rst, where |
@@ -102,20 +102,20 @@ Export videos | |||
pixels[i, j, k] = ti.random() * 255 | |||
|
|||
result_dir = "./results" | |||
video_manger = ti.VideoManager(output_dir=result_dir, framerate=24, automatic_build=False) | |||
video_manager = ti.VideoManager(output_dir=result_dir, framerate=24, automatic_build=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also fix the one in examples/export_videos.py
?
Umm, It seems just now I have responsed that problem here IMO it's not a typo. For example, If I say
then
It is Do you mean that |
Codecov Report
@@ Coverage Diff @@
## master #1312 +/- ##
==========================================
+ Coverage 66.36% 66.68% +0.32%
==========================================
Files 36 36
Lines 5075 5094 +19
Branches 933 931 -2
==========================================
+ Hits 3368 3397 +29
+ Misses 1549 1539 -10
Partials 158 158
Continue to review full report at Codecov.
|
Thank @archibate for pointing out a typo in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
Fix some typos in the doc
export_results.rst
as @archibate mentioned.