-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IPython] [opengl] Make OpenGL kernel print work in IPython & IDLE #1303
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
=======================================
Coverage 85.50% 85.50%
=======================================
Files 19 19
Lines 3352 3353 +1
Branches 622 622
=======================================
+ Hits 2866 2867 +1
Misses 356 356
Partials 130 130
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Note that this only fix for the OpenGL backend. Please unify the CPU+CUDA (@yuanming-hu) and Metal (@k-ye) behavior to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
I think it makes sense to always call ti.sync
after kernels with print
. When people are printing (e.g. for debugging purposes), they usually don't really care about performance.
Co-authored-by: Yuanming Hu <[email protected]>
But how do I hook kernel invocations? According to your comments in |
We can do that in the C++ part. |
No, we have to perform a Python |
Related issue = depends #1222
[Click here for the format server]