Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Support "ti.cache_read_only" #1276

Merged
merged 5 commits into from
Jun 18, 2020

Conversation

yuanming-hu
Copy link
Member

Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bool found = false;
for (auto s : current_offload->scratch_opt) {
if (s.first == 1 && get_ch->output_snode == s.second) {
found = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it found in the current read-only cache or what?

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #1276 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1276   +/-   ##
=======================================
  Coverage   65.65%   65.65%           
=======================================
  Files          36       36           
  Lines        5069     5069           
  Branches      929      929           
=======================================
  Hits         3328     3328           
  Misses       1569     1569           
  Partials      172      172           
Impacted Files Coverage Δ
python/taichi/lang/__init__.py 73.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa4f79...379a584. Read the comment docs.

@yuanming-hu yuanming-hu merged commit d2f782b into taichi-dev:master Jun 18, 2020
@yuanming-hu yuanming-hu deleted the read-only-cache branch June 18, 2020 20:16
@FantasyVR FantasyVR mentioned this pull request Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants