Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] [test] Improve code coverage in Matrix #1275

Merged
merged 3 commits into from
Jun 19, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Jun 18, 2020

Related issue = This PR is a broken down stage from #1214, which originally try to do both SNode + Matrix coverage improvement.
Let's try to merge this first since it's really trivial comparing to #1214.

[Click here for the format server]


@archibate archibate added the python Python engineering related label Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #1275 into master will increase coverage by 0.15%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
+ Coverage   84.89%   85.04%   +0.15%     
==========================================
  Files          18       18              
  Lines        3276     3277       +1     
  Branches      615      616       +1     
==========================================
+ Hits         2781     2787       +6     
+ Misses        360      354       -6     
- Partials      135      136       +1     
Impacted Files Coverage Δ
python/taichi/lang/matrix.py 85.76% <88.88%> (+0.96%) ⬆️
python/taichi/lang/util.py 61.67% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5304ed5...2ea00b2. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks! Just a few nits.

Thanks for breaking down your PRs into smaller pieces. This makes reviewing a lot easier.

docs/syntax.rst Outdated Show resolved Hide resolved
docs/syntax.rst Outdated Show resolved Hide resolved
docs/syntax.rst Outdated Show resolved Hide resolved
python/taichi/lang/matrix.py Outdated Show resolved Hide resolved
@archibate archibate requested a review from yuanming-hu June 19, 2020 03:11
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@yuanming-hu yuanming-hu merged commit 36d1392 into taichi-dev:master Jun 19, 2020
@FantasyVR FantasyVR mentioned this pull request Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python engineering related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants