-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lang] [test] Improve code coverage in Matrix #1275
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
==========================================
+ Coverage 84.89% 85.04% +0.15%
==========================================
Files 18 18
Lines 3276 3277 +1
Branches 615 616 +1
==========================================
+ Hits 2781 2787 +6
+ Misses 360 354 -6
- Partials 135 136 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks! Just a few nits.
Thanks for breaking down your PRs into smaller pieces. This makes reviewing a lot easier.
Co-authored-by: Yuanming Hu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Related issue = This PR is a broken down stage from #1214, which originally try to do both SNode + Matrix coverage improvement.
Let's try to merge this first since it's really trivial comparing to #1214.
[Click here for the format server]