Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add coverage threshold to make codecov not fail so easily #1246

Merged
merged 4 commits into from
Jun 14, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate requested review from yuanming-hu and k-ye June 14, 2020 09:24
@archibate archibate changed the title [test] Add coverage threshold to make codecov not cross so much [test] Add coverage threshold to make codecov not fail so easily Jun 14, 2020
@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #1246 into master will decrease coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
- Coverage   83.97%   83.39%   -0.59%     
==========================================
  Files          18       18              
  Lines        3258     3258              
  Branches      608      608              
==========================================
- Hits         2736     2717      -19     
- Misses        387      402      +15     
- Partials      135      139       +4     
Impacted Files Coverage Δ
python/taichi/lang/common_ops.py 87.29% <0.00%> (-3.32%) ⬇️
python/taichi/lang/matrix.py 82.60% <0.00%> (-2.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1402c4e...d3380a1. Read the comment docs.

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, but I guess we need to agree on the threshold? (I don't have a good sense on this, but personally I'm fine relaxing it a bit more)

tests/python/test_matrix.py Outdated Show resolved Hide resolved
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 2% sounds like a reasonable threshold. Let's see how it works. Thank you!

@yuanming-hu yuanming-hu merged commit 7dc3054 into taichi-dev:master Jun 14, 2020
@FantasyVR FantasyVR mentioned this pull request Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants