Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opengl] [Bug] Fix crash with old GLX #1134

Closed
wants to merge 8 commits into from

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Jun 4, 2020

Related issue = #958 #1106

@TroyZhai do you have a taichi dev setup to help me test if the problem is gone? Many thanks!
Hope this could resolve your issue systematically :)
more tests required.

[Click here for the format server]

A similar issue: http://www.mujoco.org/forum/index.php?threads/segmentation-fault-when-running-bin-simulate-on-ubuntu-16-04.3512/ or glfw/glfw#1096
Related pieces in GLFW: https://github.com/glfw/glfw/blob/e0c77f71f90e3bb8495c5c88fb0fb054d71cf7fc/src/glx_context.c#L62-L66

@archibate archibate added dependency opengl OpenGL backend GAMES201 GAMES 201 students' wishlist labels Jun 4, 2020
@archibate archibate added this to the v0.6.8 milestone Jun 4, 2020
@zhai-xiao
Copy link
Contributor

@archibate Sure thing, hold on

@archibate archibate marked this pull request as draft June 4, 2020 02:28
@archibate archibate changed the title [opengl] [Bug] fix crash when OpenGL version < 4.3 [opengl] [Bug] fix crash with old GLX Jun 4, 2020
@Eydcao
Copy link
Contributor

Eydcao commented Jun 4, 2020

Incredible speed @archibate ! I will also give it a try, just a sec.

@archibate
Copy link
Collaborator Author

Bad news: it makes OpenGL not work on my machine too.

@Eydcao
Copy link
Contributor

Eydcao commented Jun 4, 2020

Bad news: it makes OpenGL not work on my machine too.

Still incredible speed :>, I could help test when you make another fix again

@archibate
Copy link
Collaborator Author

Thank for the patience! Given the address traceback. Could you run objdump -D /lib/libGLX_mesa.so | grep 35bf.: for me?

@Eydcao
Copy link
Contributor

Eydcao commented Jun 4, 2020

Thank for the patience! Given the address traceback. Could you run objdump -D /lib/libGLX_mesa.so | grep 35bf.: for me?

objdump: '/lib/libGLX_mesa.so': No such file

It says

@archibate
Copy link
Collaborator Author

Oh, sorry! It's /lib/x86_64-linux-gnu/libGLX_mesa.so.

@Eydcao
Copy link
Contributor

Eydcao commented Jun 4, 2020

Oh, sorry! It's /lib/x86_64-linux-gnu/libGLX_mesa.so.

This PC does not have it still, but in the same dir I found libGLX_mesa.so.0 and libGLX_mesa.so.0.0.0. Attached screenshots here

image

image

@archibate
Copy link
Collaborator Author

archibate commented Jun 4, 2020

The information is really helpful! I added some hooks in _glfwInitGLX(), could you retrieve the latest commit of this PR and run git submodule update --init then build + import taichi to see what message it prints? (should be G0~G20, of course, no rush at all :)

@Eydcao
Copy link
Contributor

Eydcao commented Jun 4, 2020

The information is really helpful! I added some hooks in _glfwInitGLX(), could you retrieve the latest commit of this PR and run git submodule update --init then build + import taichi to see what message it prints? (should be G0~G20, of course, no rush at all :)

No problem, please hold on

@archibate
Copy link
Collaborator Author

What's your glx version?

@Eydcao
Copy link
Contributor

Eydcao commented Jun 4, 2020

What's your glx version?

1.4

@archibate
Copy link
Collaborator Author

That's strange... my glx is also 1.4..

@Eydcao
Copy link
Contributor

Eydcao commented Jun 4, 2020

The information is really helpful! I added some hooks in _glfwInitGLX(), could you retrieve the latest commit of this PR and run git submodule update --init then build + import taichi to see what message it prints? (should be G0~G20, of course, no rush at all :)

image

@archibate archibate self-assigned this Jun 5, 2020
@yuanming-hu yuanming-hu changed the title [opengl] [Bug] fix crash with old GLX [opengl] [Bug] Fix crash with old GLX Jun 6, 2020
@archibate archibate modified the milestones: v0.6.8, v0.6.9 Jun 6, 2020
@archibate archibate removed their assignment Jun 8, 2020
@archibate archibate added the stale stale issues and PRs label Jun 8, 2020
@archibate archibate closed this Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GAMES201 GAMES 201 students' wishlist opengl OpenGL backend stale stale issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants