Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aot] Breaking changes in C-API before release! #6693

Closed
4 tasks
PENGUINLIONG opened this issue Nov 21, 2022 · 0 comments
Closed
4 tasks

[aot] Breaking changes in C-API before release! #6693

PENGUINLIONG opened this issue Nov 21, 2022 · 0 comments
Assignees
@PENGUINLIONG
Labels
feature request Suggest an idea on this project
Milestone
v1.4.0

Comments

@PENGUINLIONG
Copy link
Member

PENGUINLIONG commented Nov 21, 2022 •
edited
Loading

This issue tracks all breaking changes in Taichi Runtime C-API should be applied before its official release. These changes are not immediately applied because many internal/external projects relies on them and things are subject to change. They ultimately have to be done tho.

  • Rename ti_submit to ti_flush.
  • Remove third party header includes in taichi/taichi.h.
  • Breaking function signature: TiRuntime ti_create_runtime(TiArch arch, uint32_t device_index).
  • Remove TiEvent.
@PENGUINLIONG PENGUINLIONG added the feature request Suggest an idea on this project label Nov 21, 2022
@PENGUINLIONG PENGUINLIONG added this to the 1.4.0 milestone Nov 21, 2022
@PENGUINLIONG PENGUINLIONG self-assigned this Nov 21, 2022
@taichi-gardener taichi-gardener moved this to Untriaged in Taichi Lang Nov 21, 2022
@ailzhang ailzhang moved this from Untriaged to In Progress in Taichi Lang Nov 25, 2022
@PENGUINLIONG PENGUINLIONG mentioned this issue Dec 22, 2022
Merged
PENGUINLIONG added a commit that referenced this issue Dec 23, 2022
@PENGUINLIONG @pre-commit-ci
[aot] C-API breaking changes! (#6955)
aa46e71 
Issue: #6693, taichi-dev/taichi-aot-demo#101,
taichi-dev/taichi-unity2#9

### Brief Summary

This PR introduced the breaking changes listed in #6693.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Taichi Lang Jan 4, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this issue May 13, 2023
@PENGUINLIONG @pre-commit-ci @quadpixels
[aot] C-API breaking changes! (taichi-dev#6955)
960c3b1 
Issue: taichi-dev#6693, taichi-dev/taichi-aot-demo#101,
taichi-dev/taichi-unity2#9

### Brief Summary

This PR introduced the breaking changes listed in taichi-dev#6693.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PENGUINLIONG PENGUINLIONG

Labels
feature request Suggest an idea on this project
Projects
Taichi Lang
Status: Done
Milestone
v1.4.0
Development

No branches or pull requests
1 participant
@PENGUINLIONG