Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate namespace macros #6147

Closed
lin-hitonami opened this issue Sep 23, 2022 · 2 comments · Fixed by #6163
Closed

Eliminate namespace macros #6147

lin-hitonami opened this issue Sep 23, 2022 · 2 comments · Fixed by #6163
Labels
feature request Suggest an idea on this project

Comments

@lin-hitonami
Copy link
Contributor

Concisely describe the proposed feature
Currently we have macros TLANG_NAMESPACE_BEGIN/END which are equivalent to namespace taichi::lang {}. The macros may confuse the first-time readers so let's change it to namespace taichi::lang {}.
@lin-hitonami lin-hitonami added the feature request Suggest an idea on this project label Sep 23, 2022
@taichi-gardener taichi-gardener moved this to Untriaged in Taichi Lang Sep 23, 2022
@strongoier
Copy link
Contributor

Is this part of #2198?

@lin-hitonami
Copy link
Contributor Author

Yeah. I'll replace the macros some time later.

@lin-hitonami lin-hitonami moved this from Untriaged to Backlog in Taichi Lang Sep 23, 2022
This was referenced Sep 23, 2022
Merged
Merged
Repository owner moved this from Backlog to Done in Taichi Lang Sep 26, 2022
lin-hitonami added a commit that referenced this issue Sep 26, 2022
@lin-hitonami
[misc] Remove TI_UI namespace macros (#6163)
e8dc076 
Issue: fixes #6147 

### Brief Summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Suggest an idea on this project
Projects
Taichi Lang
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[misc] Remove TI_UI namespace macros lin-hitonami/taichi
2 participants
@strongoier @lin-hitonami