Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog should be generated before tagging latest version #6114

Closed
strongoier opened this issue Sep 20, 2022 · 0 comments
Closed

Changelog should be generated before tagging latest version #6114

strongoier opened this issue Sep 20, 2022 · 0 comments
Assignees
Labels
potential bug Something that looks like a bug but not yet confirmed release
Milestone

Comments

@strongoier
Copy link
Contributor

In the release of v1.1.3, the workflow generates an incomplete changelog (https://github.com/taichi-dev/taichi/actions/runs/3087352313/jobs/4993540670):

Highlights: Full changelog: - [bug] [gui] Fix a bug of drawing mesh instacing that cpu/cuda objects have an offset when copying to vulkan object (#6028) (by **Mocki**)

It seems that the latest version has been tagged before changelog generation. However, the setting looks correct:

- name: Generate Changelog
id: changelog
run: |
pip3 install gitpython
content=$(python3 misc/make_changelog.py)
echo $content
# Escape multiline strings:
# https://renehernandez.io/snippets/multiline-strings-as-a-job-output-in-github-actions/
content="${content//'%'/'%25'}"
content="${content//$'\n'/'%0A'}"
content="${content//$'\r'/'%0D'}"
echo "::set-output name=content::$content"
- name: Create tag
run: |
git config user.email "[email protected]"
git config user.name "Taichi Gardener"
git tag -a ${RELEASE_VERSION} -m "Release ${RELEASE_VERSION}"
git push origin --tags

There must be something wrong. If we don't fix it, we will have to locally generate the changelog and manually paste it immediately after each release.

@strongoier strongoier added the potential bug Something that looks like a bug but not yet confirmed label Sep 20, 2022
@taichi-gardener taichi-gardener moved this to Untriaged in Taichi Lang Sep 20, 2022
@strongoier strongoier added this to the v1.1.4 milestone Sep 20, 2022
@turbo0628 turbo0628 moved this from Untriaged to In Progress in Taichi Lang Sep 23, 2022
@jim19930609 jim19930609 modified the milestones: v1.1.4, v1.2.0 Oct 18, 2022
@ailzhang ailzhang modified the milestones: v1.2.0, v1.3.0 Nov 10, 2022
@strongoier strongoier modified the milestones: v1.3.0, v1.4.0 Nov 25, 2022
feisuzhu added a commit that referenced this issue Jan 5, 2023
@feisuzhu feisuzhu closed this as completed Jan 5, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Taichi Lang Jan 5, 2023
PGZXB pushed a commit to PGZXB/taichi that referenced this issue Jan 5, 2023
lin-hitonami added a commit that referenced this issue Jan 13, 2023
Issue: #6114

### Brief Summary
The changelog automatically generated by GitHub only shows the PR list
related to the branch, and the cherry-picked commits are not inside the
list. So we should use our commit-based `make_changelog.py` to generate
the full changelog.
lin-hitonami added a commit that referenced this issue Jan 13, 2023
Issue: #6114

### Brief Summary
The changelog automatically generated by GitHub only shows the PR list
related to the branch, and the cherry-picked commits are not inside the
list. So we should use our commit-based `make_changelog.py` to generate
the full changelog.
quadpixels pushed a commit to quadpixels/taichi that referenced this issue May 13, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this issue May 13, 2023
…#7152)

Issue: taichi-dev#6114

### Brief Summary
The changelog automatically generated by GitHub only shows the PR list
related to the branch, and the cherry-picked commits are not inside the
list. So we should use our commit-based `make_changelog.py` to generate
the full changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential bug Something that looks like a bug but not yet confirmed release
Projects
Status: Done
Development

No branches or pull requests

4 participants