-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog should be generated before tagging latest version #6114
Labels
Milestone
Comments
strongoier
added
the
potential bug
Something that looks like a bug but not yet confirmed
label
Sep 20, 2022
PGZXB
pushed a commit
to PGZXB/taichi
that referenced
this issue
Jan 5, 2023
Issue: taichi-dev#6114 ### Brief Summary
lin-hitonami
added a commit
that referenced
this issue
Jan 13, 2023
Issue: #6114 ### Brief Summary The changelog automatically generated by GitHub only shows the PR list related to the branch, and the cherry-picked commits are not inside the list. So we should use our commit-based `make_changelog.py` to generate the full changelog.
lin-hitonami
added a commit
that referenced
this issue
Jan 13, 2023
Issue: #6114 ### Brief Summary The changelog automatically generated by GitHub only shows the PR list related to the branch, and the cherry-picked commits are not inside the list. So we should use our commit-based `make_changelog.py` to generate the full changelog.
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this issue
May 13, 2023
Issue: taichi-dev#6114 ### Brief Summary
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this issue
May 13, 2023
…#7152) Issue: taichi-dev#6114 ### Brief Summary The changelog automatically generated by GitHub only shows the PR list related to the branch, and the cherry-picked commits are not inside the list. So we should use our commit-based `make_changelog.py` to generate the full changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the release of v1.1.3, the workflow generates an incomplete changelog (https://github.com/taichi-dev/taichi/actions/runs/3087352313/jobs/4993540670):
It seems that the latest version has been tagged before changelog generation. However, the setting looks correct:
taichi/.github/workflows/release.yml
Lines 454 to 472 in 02822e7
There must be something wrong. If we don't fix it, we will have to locally generate the changelog and manually paste it immediately after each release.
The text was updated successfully, but these errors were encountered: